Comments on: Code Reviews – Mandatory but Ad-Hoc?

By: Developers think code reviews are great… what? | >kloctalk

Developers think code reviews are great… what? | >kloctalk — Tue, 01 Jun 2010 15:33:25 +0000

[...] professionals a whole bunch of questions related to code reviews (some of which we’ve referenced before) and here are two interesting data points that suggest developers see real benefits from code [...]

By: laurance

laurance — Tue, 30 Mar 2010 04:12:43 +0000

Hello from England! I have found your domain on alltheweb. Good content! Mary J. Hamilton x

By: Brendan Harrison

Brendan Harrison — Fri, 19 Mar 2010 12:47:17 +0000

Good points Gregg, thanks for chiming in. The last point about more structure = more resistance is an interesting one… embracing a more unstructured approach with some tool and easy workflow support is an approach many organizations seem to be taking.

By: Gregg Sporar

Gregg Sporar — Thu, 18 Mar 2010 17:32:25 +0000

“Shouldn’t who reviews the code be pretty important?”

Yes, but… it’s frequently not that simple. For some teams that we’ve worked with, there are subject matter experts whose inclusion is required but that does not mean they are the *only* members of the team allowed on the review.

For some teams, only one member of the group of subject matter experts is required and there is flexibility as to which specific member is assigned to any particular review. That provides a way to do a bit of load balancing.

And then for other teams, they prefer a wide open approach because too much structure will generate resistance to the idea of doing code review at all.

So there is no one size fits all rule.